This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow Accept-Encoding header to be set explicitly by http request #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test case? |
|
Ok will give it a try :) |
|
The actual cause of the problem was that Zend\Http\Client::prepareHeaders() used different case for the header name, Accept-encoding vs. Accept-Encoding. When merging the headers from the request object within $headers later on, instead of replacing the default one there would end up 2 Accept-Encoding headers in $headers, one keyed "Accept-encoding" and another one keyed "Accept-Encoding". I fixed the naming and added a test as well. |
weierophinney
added a commit
that referenced
this pull request
Dec 10, 2012
- Added import for SetCookie HTTP header
weierophinney
added a commit
that referenced
this pull request
Dec 10, 2012
Forward port #2962 Conflicts: tests/ZendTest/Http/ClientTest.php
ghost
assigned
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
- Added import for SetCookie HTTP header
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
Forward port zendframework/zendframework#2962 Conflicts: tests/ZendTest/Http/ClientTest.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it does not seem possible to override the Accept-Encoding header, I think because of some code in Zend\Http\Client::prepareHeaders that uses an undefined $headers member variable while it should check if the header is already explicitly set in the request.