This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow NodeList to be accessed via array like syntax. #3078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we do a execute a selector and get back a NodeList and want just the first element we can now access it like so:
~~~ php
<?php
use Zend\Dom\Query;
$dom = new Query($html);
$results = $dom->execute('.foo .bar a');
$count = count($results); // get number of matches: 4
$results[2]->getAttribute('id'); // access individually
foreach ($results as $result) { // or iterate
// $result is a DOMElement
}
?>
~~~
Where before you could only iterate them which is really ineffective for a lot of projects.
|
👍 |
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Dec 10, 2012
- DOMXPath::query() no longer raises an exception on failure; it now raises an E_WARNING. Updated code to detect an E_WARNING and raise an exception when discovered.
|
Found an issue with PHP >= 5.4.1 -- DOMXPath::query() no longer throws an exception when it encounters extensions it does not know about. Updated the code to use the ErrorHandler so it can detect these situations. Also: merged only to develop, as this is a new feature. It will release with 2.1.0. |
weierophinney
added a commit
to zendframework/zend-dom
that referenced
this pull request
May 15, 2015
- DOMXPath::query() no longer raises an exception on failure; it now raises an E_WARNING. Updated code to detect an E_WARNING and raise an exception when discovered.
weierophinney
added a commit
to zendframework/zend-dom
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we do a execute a selector and get back a NodeList and want just the first element we can now access it like so:
Where before you could only iterate them which is really ineffective for a lot of projects.