This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Zend/Di, retriving same shared instance for different extra parameters #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return array | ||
| */ | ||
|
|
||
| public function _getCallParameters($name, array $params, $method = "__construct") |
There was a problem hiding this comment.
Why the "_" prefix on the method?
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Jan 2, 2013
- Removed "_" prefix from getCallParameters() - whitespace between operators and parens - added braces to logic blocks
|
Merged, and corrected all CS issues at the same time. |
|
Thanks, Matthew |
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
- Removed "_" prefix from getCallParameters() - whitespace between operators and parens - added braces to logic blocks
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-di
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created an fix for issue #3192, about a problem which I got. Also, I made a simple test for my situation and add it to tests/ZendTests/Di/DiTest.php.