Change generated CSR version to 0 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested this to verify it actually works against boulder? (per the now-removed comment, I assume this fixed some problem at some point). (Relatedly, we should get the integration tests running in CI again; we never moved to something else after travis shut down) I think I will want to try dogfooding this before merging. Fortunately it's getting to be time to renew my own certs, so that should happen soonish. |
|
Yep it works there. Also certbot also has changed this too. |
|
Seems to work for me. Merging. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSRs are PKCS#10 documents, and the standard does not define versions above 0.
Reference: certbot/certbot#9334