Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for php < 8, add string types, add german translation, minor fixes #35

Merged
merged 2 commits into from
Oct 3, 2022
Merged

feat: drop support for php < 8, add string types, add german translation, minor fixes #35

merged 2 commits into from
Oct 3, 2022

Conversation

Chris53897
Copy link
Contributor

I know it is maybe a bit early for dropping php 8.
But as you are maintaining so many great bundles, it is better so be prepared.
Please have a look for BC breaks. As of course the strong types will be.

This is to fix the deprecation of NULL as Param in ltrim()
Code could be better, but it works.
https://github.com/kbond/ZenstruckRedirectBundle/compare/master...Chris53897:ZenstruckRedirectBundle:feature/drop-support-php-7.x?expand=1#diff-4ba8cd4a4825e89fd7af82dd6413ebd66fac5a052b1e1c811a147326d2578e0eR102

I thought about changing the EntityMapping from Annotations to Attributes. But this PR is already big.

@Chris53897
Copy link
Contributor Author

I fixed files local with php-cs-fixer on mac. Now it has linting errors, which i think is maybe just an option in config.
But should be handled in a different PR.

@sadikoff
Copy link
Contributor

Hi 👋🏻

Any plans to merge it?

@kbond
Copy link
Member

kbond commented Sep 30, 2022

Hi, sorry, missed this one. Will review today!

@kbond kbond merged commit e6e8d17 into zenstruck:master Oct 3, 2022
@kbond
Copy link
Member

kbond commented Oct 3, 2022

Thanks @Chris53897, released as 3.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants