Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pstrb signal name #149

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Fix pstrb signal name #149

merged 2 commits into from
Jul 26, 2024

Conversation

zephray
Copy link
Contributor

@zephray zephray commented Jul 26, 2024

According to the APB spec, the signal should be named as PSTRB rather than PWSTRB

@zephray zephray requested a review from azaidy July 26, 2024 18:13
azaidy
azaidy approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@azaidy azaidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving it. Please dont merge until CI passes.

@gadfort
Copy link
Contributor

gadfort commented Jul 26, 2024

@zephray only one failure now, could you remove the call to 'option', 'mode' in the failing test, that should solve things

@azaidy
Copy link
Contributor

azaidy commented Jul 26, 2024 •
edited
Loading

@gadfort, @zephray, I removed the call to option, mode in the failing test

@azaidy azaidy merged commit c9ce1a9 into main Jul 26, 2024
16 checks passed
@azaidy azaidy deleted the apb_name_fix branch July 26, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azaidy azaidy azaidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zephray @gadfort @azaidy