Fix Solaris mismatch where snapshot labels cannot be enabled when snapshots are disabled globally #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match the Solaris implementation, it should be possible to disable all snapshots via the com.sun:auto-snapshot property, and subsequently override that parameter by explicitly enabling individual labels. This is achieved when opt_default_exclude is disabled (the default behavior) by adding datasets for which the label is explicitly enabled to CANDIDATES.
rzumer
changed the title
rzumer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the Solaris implementation, it should be possible to disable all snapshots via the
com.sun:auto-snapshotproperty, and subsequently override that parameter by explicitly enabling individual labels.This is achieved when opt_default_exclude is disabled (the default behavior) by adding datasets for which the label is explicitly enabled (
com.sun:auto-snapshot:<label>=true) to CANDIDATES regardless of the value ofcom.sun:auto-snapshot.That will allow users to ignore all automatic snapshots except for weekly ones via
zfs set com.sun:auto-snapshot=false dataset; zfs set com.sun:auto-snapshot:weekly=true dataset, as documented here. Right nowweeklywill still be skipped in this scenario.I tested the awk selector to make sure the correct datasets would be returned on my system, but I have a simple hierarchy and configuration, so I may not be aware of implications of this change on more complex hierarchies.
Fixes #127.