This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
fix unhandled exception on scan timeout #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adminiuga
reviewed
Jan 22, 2020
|
Reverting this. It breaks "failed devices" logic. Time out exceptions are supposed to be handled in zha-map/custom_components/zha_map/__init__.py Line 138 in 9ef57df |
Adminiuga
added a commit
that referenced
this pull request
Feb 16, 2020
This reverts commit 49fb8c7.
Adminiuga
added a commit
that referenced
this pull request
Feb 16, 2020
Adminiuga
added a commit
that referenced
this pull request
Feb 29, 2020
* Initial commit. * Scan all discovered neighbours. Sanity check after scan is finished. * Start initial scan after a delay. * isort imports. * Handle unknown neigbours. * Handle failures gracefuly. Don't include failed devices in next scan. Don't scan devices not present in `zigbee.db`. * scan_now service. * Black format. * Expose "current" topology through a property. * Fix handling of devices not in db. * Add WS command. * "offline" property. Neighbours are assumed to be online by default. Only neigbours which were attempted to be scanned and failed are marked offline. This implies that Zigbee End Devices are always online, because they are never attempted to be scanned. * Add "neighbours" missing in neighobour table. Add devices as "offline" if present in zigbee.db, but not found in neighbours. * Make sure device_typs always has a value. * Skip devices not supporting ZDO lqi_mgmt_req. Samjin multisensor reports itself as a router, even though it is an end device. * return timestamp in WS call (#2) * ignore invalid neighbours reported by some devices (#1) * Ignore 00:00:00:00:00:00:00:00 neighbours. * Fix IEEE conversions. * Use node descriptor only if available. Derive device type from node descriptor (authorative) only if avaiable ie device is online. * Doh. * Use hex representation for NWK addresses. * Black format code. * Update neighbour.py (#4) prevent infinity loop * fix unhadled exception on scan timeout (#5) * Update README.md with usage instruction (#7) Update README.md with usage instruction - Credits goes to eszkjc on Reddit https://www.reddit.com/r/homeassistant/comments/eszkjc/zigbee_network_mapping_with_zha_my_77_node_network/ https://www.reddit.com/r/homeassistant/comments/eszkjc/zigbee_network_mapping_with_zha_my_77_node_network/ * Revert "fix unhadled exception on scan timeout (#5)" (#10) This reverts commit 49fb8c7. * Create info.md * Create LICENSE (#12) * Update info.md Co-authored-by: Abílio Costa <abmantis@users.noreply.github.com> Co-authored-by: jkkwon83 <jkkwon83@gmail.com> Co-authored-by: Andreas Setterlind <Gamester17@users.noreply.github.com>
Adminiuga
added a commit
that referenced
this pull request
Feb 29, 2020
* Initial commit. * Scan all discovered neighbours. Sanity check after scan is finished. * Start initial scan after a delay. * isort imports. * Handle unknown neigbours. * Handle failures gracefuly. Don't include failed devices in next scan. Don't scan devices not present in `zigbee.db`. * scan_now service. * Black format. * Expose "current" topology through a property. * Fix handling of devices not in db. * Add WS command. * "offline" property. Neighbours are assumed to be online by default. Only neigbours which were attempted to be scanned and failed are marked offline. This implies that Zigbee End Devices are always online, because they are never attempted to be scanned. * Add "neighbours" missing in neighobour table. Add devices as "offline" if present in zigbee.db, but not found in neighbours. * Make sure device_typs always has a value. * Skip devices not supporting ZDO lqi_mgmt_req. Samjin multisensor reports itself as a router, even though it is an end device. * return timestamp in WS call (#2) * ignore invalid neighbours reported by some devices (#1) * Ignore 00:00:00:00:00:00:00:00 neighbours. * Fix IEEE conversions. * Use node descriptor only if available. Derive device type from node descriptor (authorative) only if avaiable ie device is online. * Doh. * Use hex representation for NWK addresses. * Black format code. * Update neighbour.py (#4) prevent infinity loop * fix unhadled exception on scan timeout (#5) * Update README.md with usage instruction (#7) Update README.md with usage instruction - Credits goes to eszkjc on Reddit https://www.reddit.com/r/homeassistant/comments/eszkjc/zigbee_network_mapping_with_zha_my_77_node_network/ https://www.reddit.com/r/homeassistant/comments/eszkjc/zigbee_network_mapping_with_zha_my_77_node_network/ * Revert "fix unhadled exception on scan timeout (#5)" (#10) This reverts commit 49fb8c7. * Create info.md * Create LICENSE (#12) * Update info.md * Create hacs.json Co-authored-by: Abílio Costa <abmantis@users.noreply.github.com> Co-authored-by: jkkwon83 <jkkwon83@gmail.com> Co-authored-by: Andreas Setterlind <Gamester17@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.