compiler: shorten the name of inferred error unions #19425
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consider the following Zig code:
under status quo you might get an error like so:
this, while technically accurate, is extremely verbose and not practically useful in most cases (it doesnt even fit in the default width of the github view!). many advanced users see it as noise and beginners get overwhelmed while they are still grasping Zig's error system. alternatively, this patch reduces it to the following.
now the "error union type does not support field access" text is much more accessible and the
!
is retained to match the return types users see in functions that produce this message.additionally added a test to ensure error messages with functions that have an explicit error set are retained.
further work would add a note where
x
in this example is defined but i decided to save that for a subsequent pr.