Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symfony 6 compatibility issue #21

Closed
On5-Repos opened this issue Sep 6, 2023 · 8 comments
Closed

symfony 6 compatibility issue #21

On5-Repos opened this issue Sep 6, 2023 · 8 comments

Comments

@On5-Repos
Copy link
Contributor

Package is locked to [symfony/contracts]: ^2

but above package been remove in 6 and replaced with symfony/deprecation-contracts

Can this be fixed? currently we are unable to upgrade from 5.4 to 6

@craigh
Copy link
Member

craigh commented Sep 6, 2023

Hi @On5-Repos I'm willing to change it but would like to maintain compatibility with 5.4. Any idea how to do that?

@On5-Repos
Copy link
Contributor Author

I am running some tests to keep compatibility and I will report back soon.

@craigh
Copy link
Member

craigh commented Sep 6, 2023

I think we just need to replace

        "symfony/contracts": "^2",

with

        "symfony/event-dispatcher-contracts": "^2.0 || ^3.0",
        "symfony/translation-contracts": "^2.0 || ^3.0",

@On5-Repos
Copy link
Contributor Author

yes correct it seems to work

@craigh
Copy link
Member

craigh commented Sep 6, 2023

changed here

@craigh craigh closed this as completed Sep 6, 2023
@craigh
Copy link
Member

craigh commented Sep 6, 2023

but now a bunch of stuff is broken in tests and things... I hope it still works for you. I don't have time to fix it up in the near future. I would welcome a PR to correct.

@craigh craigh reopened this Sep 6, 2023
@On5-Repos
Copy link
Contributor Author

leave the issue open I will work on it and report back.

@On5-Repos
Copy link
Contributor Author

#22

@craigh craigh closed this as completed Sep 15, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants