Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Unit tests #22

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Update Unit tests #22

merged 1 commit into from
Sep 7, 2023

Conversation

On5-Repos
Copy link
Contributor

Update DynamicFieldsTypeTest ... and all tests are successful.

@craigh
Copy link
Member

craigh commented Sep 7, 2023

Thank you @On5-Repos

All tests are passing, but apparently the phpcs-fixer config defaults have changed since the last release so now that is also failing.

I'll merge this anyway. Any chance you want to take a shot at changing the phpcs-fixer config to allow current?

@craigh craigh merged commit ce3b936 into zikula:main Sep 7, 2023
9 of 14 checks passed
@On5-Repos
Copy link
Contributor Author

If you keep backwards compatibility for php 7.4 then its difficult. with php 8.0 / 8.1 handful of symfony core packages do get updated which are not compatible with 7.4. When i switch to 8.1 and check phpcs-fixer etc everything is good with 14 fixes. but Switching back to 7.4 --- errors regarding packages install are not compatible with 7.4 ... do you want to keep 7.4?

@craigh
Copy link
Member

craigh commented Sep 8, 2023

I'd like to figure out a way to keep both. I'm sure there must be a way.

@On5-Repos
Copy link
Contributor Author

hey I am sorry been so busy with work i did not had chance to work on this, I will try to do it this week

@craigh
Copy link
Member

craigh commented Sep 15, 2023

@On5-Repos I'm working on it right now actually. Stay tuned.

@craigh
Copy link
Member

craigh commented Sep 15, 2023

@On5-Repos released!

@On5-Repos
Copy link
Contributor Author

cool i will review and report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants