Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider re-enabling the latest Node.js 22 version on CI #239

Closed
diego-aquino opened this issue Jul 3, 2024 · 1 comment · Fixed by #242
Closed

Consider re-enabling the latest Node.js 22 version on CI #239

diego-aquino opened this issue Jul 3, 2024 · 1 comment · Fixed by #242
Assignees
@diego-aquino
Labels
workflow Development workflow
Milestone
v0.8.0

Comments

@diego-aquino
Copy link
Member

diego-aquino commented Jul 3, 2024 •
edited
Loading

Node.js 22.4 is out and it should have fixed nodejs/undici#3337, which broke some of our tests. If the tests continue to pass in 22.4 as they have in 22.2, we should remove the 22.2 restriction in CI and return to using the latest 22 version.
@diego-aquino diego-aquino added this to the v0.8.0 milestone Jul 3, 2024
@diego-aquino diego-aquino self-assigned this Jul 3, 2024
@diego-aquino diego-aquino mentioned this issue Jul 3, 2024
Merged
diego-aquino added a commit that referenced this issue Jul 3, 2024
@diego-aquino
chore(ci): latest node 22 (#242)
a936957 
### Chore
- [ci] Re-enabled the latest node 22 version on CI, now that 22.4 is
out. Previously, we fixed 22.2 because 22.3 had a [bug related to array
buffers](nodejs/undici#3337) that was causing
some tests to fail.

Closs #239.
@diego-aquino diego-aquino linked a pull request Jul 7, 2024 that will close this issue
chore(ci): latest node 22 (#239) #242
Merged
@diego-aquino diego-aquino added the workflow Development workflow label Jul 9, 2024
@github-actions GitHub Actions
Copy link

Released in v0.8.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diego-aquino diego-aquino

Labels
workflow Development workflow
Projects
Zimic
Status: Done
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

chore(ci): latest node 22 (#239) zimicjs/zimic
1 participant
@diego-aquino