Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user config with alternate coloring #90

Merged
merged 7 commits into from
Oct 31, 2022

Conversation

3ter
Copy link
Collaborator

@3ter 3ter commented Oct 30, 2022

This PR builds upon #89 (so this diff is going to be easier to read after it has been merged).
Update: Rebased the branch so the diff is now smaller.

Changing the value from the addons menu should make it simpler to switch between different coloring needs.

image
image
image

Resolves #88, resolves #79, resolves #68, resolves #67, resolves #48, resolves #11

@3ter 3ter added the enhancement New feature or request label Oct 30, 2022
@3ter 3ter requested a review from zjosua October 30, 2022 09:58
@3ter 3ter self-assigned this Oct 30, 2022
@3ter 3ter mentioned this pull request Oct 30, 2022
@3ter 3ter force-pushed the add-user-config-with-alternate-coloring branch from 61fe7df to 350fe70 Compare October 30, 2022 15:09
@3ter 3ter force-pushed the add-user-config-with-alternate-coloring branch from 350fe70 to 783cc60 Compare October 30, 2022 21:02
Copy link
Owner

@zjosua zjosua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review. Haven't tested yet.

src/multiple_choice/config.py Outdated Show resolved Hide resolved
src/multiple_choice/config.json Outdated Show resolved Hide resolved
src/multiple_choice/__init__.py Outdated Show resolved Hide resolved
src/multiple_choice/config.md Outdated Show resolved Hide resolved
@3ter
Copy link
Collaborator Author

3ter commented Oct 31, 2022

Preliminary review. Haven't tested yet.

Thanks a ton already!

The only deviations from your suggestion were

  • JSON and JavaScript both use lower case boolean value names (true instead of Python's True)
  • I moved all responsibility for templates to template.py

And I forgot to mention in the PR description, that I also disabled (unintentional) editing of the checkboxes after answering.

@zjosua zjosua merged commit 2a318bf into zjosua:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants