-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user config with alternate coloring #90
Merged
zjosua
merged 7 commits into
zjosua:master
from
3ter:add-user-config-with-alternate-coloring
Oct 31, 2022
Merged
Add user config with alternate coloring #90
zjosua
merged 7 commits into
zjosua:master
from
3ter:add-user-config-with-alternate-coloring
Oct 31, 2022
+241
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ter
force-pushed
the
add-user-config-with-alternate-coloring
branch
from
October 30, 2022 15:09
61fe7df
to
350fe70
Compare
Add default options (config.json) with explanations in markdown. Fix answer table still visible with option saying false.
3ter
force-pushed
the
add-user-config-with-alternate-coloring
branch
from
October 30, 2022 21:02
350fe70
to
783cc60
Compare
zjosua
reviewed
Oct 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary review. Haven't tested yet.
Improve documentation.
Fix bug with False vs false in Python vs JavaScript.
Thanks a ton already! The only deviations from your suggestion were
And I forgot to mention in the PR description, that I also disabled (unintentional) editing of the checkboxes after answering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #89 (so this diff is going to be easier to read after it has been merged).Update: Rebased the branch so the diff is now smaller.
Changing the value from the addons menu should make it simpler to switch between different coloring needs.
Resolves #88, resolves #79, resolves #68, resolves #67, resolves #48, resolves #11