-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Ansys 2022 R2 #142
Conversation
Update installation information in documentation to include conda and pypi, close #49
allows to print result and print variation to be used togther where the variation to be printed is give by an integer
Thank you will need to look at this more carefully Is it backward compatible? |
I don't currently have old ansys versions installed unfortunately. |
For any of the backward breaking changes you can add an if statement as shown in the ansys.py file that checks the version of ansys and one one thing if old and another if new Do you know what I mean? |
I see, let me try |
For backward compatibility: First, import Dispatch at the beginning of this .py Then replace previous 1579 - 1587, by:
|
Is the code backwards compatible now? |
The epr_numerical_diagonalization function uses np.float which has been deprecated in Numpy. Refer https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations The continued usage of np.float yields the following error in the epr_numerical_diaganolization function when later versions of Numpy is used. "AttributeError: module 'numpy' has no attribute 'float'." This commit replace np.float with float to solve this error.
Wondering if it would be safe to merge this into main, what do you think? |
* Fix mode selection in analyze_variation Addressing issue #148: analyze_variation incorrectly chooses Pj, Sj, Om, PHI_zpf when passed a subset of modes * Remove redundant frequency selection The frequencies are already correctly selected outside of this if-statement, so this is not necessary
Hi, only wanted to know whether this issue will be merged to main branch soon? |
You mean this PR break with Qiskit Metal use. Yes, that means it is not compatible in current form. We would want some help to fix and make not quick issues. I also have some questions in the code here too. |
I was also a bit confused before. I now notice that this PR is pulling from |
Oh I didn't even notice that it pulls into |
out-commenting a property not supported in latest version. Only visual impact
Thank you for the effort on this massive update! I just merged! Hopefully there aren't any major compatibility issues, i didn;t catch any here |
When running pyepr on ansys 2022 R2, ansys complained that it does not recognize "re(Mode(1)):Curve1". This could be related to the new version's names of the figure properties.
The way I temporarily fix this is to remove ":Curve1", and also comment out several "set_property" commands in core_distributed_analysis.py .