Skip to content

Commit

Permalink
fix some entries of comma operator
Browse files Browse the repository at this point in the history
  • Loading branch information
zloirock committed Aug 22, 2021
1 parent 4a56ece commit 67ed50d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
10 changes: 6 additions & 4 deletions packages/core-js/modules/es.reflect.set.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var createPropertyDescriptor = require('../internals/create-property-descriptor'
function set(target, propertyKey, V /* , receiver */) {
var receiver = arguments.length < 4 ? target : arguments[3];
var ownDescriptor = getOwnPropertyDescriptorModule.f(anObject(target), propertyKey);
var existingDescriptor, prototype;
var existingDescriptor, prototype, setter;
if (!ownDescriptor) {
if (isObject(prototype = getPrototypeOf(target))) {
return set(prototype, propertyKey, V, receiver);
Expand All @@ -27,9 +27,11 @@ function set(target, propertyKey, V /* , receiver */) {
existingDescriptor.value = V;
definePropertyModule.f(receiver, propertyKey, existingDescriptor);
} else definePropertyModule.f(receiver, propertyKey, createPropertyDescriptor(0, V));
return true;
}
return ownDescriptor.set === undefined ? false : (ownDescriptor.set.call(receiver, V), true);
} else {
setter = ownDescriptor.set;
if (setter === undefined) return false;
setter.call(receiver, V);
} return true;
}

// MS Edge 17-18 Reflect.set allows setting the property to object
Expand Down
6 changes: 4 additions & 2 deletions tests/compat/tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -815,8 +815,10 @@ GLOBAL.tests = {
&& /()??/.exec('')[1] === undefined
&& reSticky.exec('abc')[0] === 'a'
&& reSticky.exec('abc') === null
&& (reSticky.lastIndex = 1, reSticky.exec('bac')[0] === 'a')
&& (reStickyAnchored.lastIndex = 2, reStickyAnchored.exec('cba') === null)
&& (reSticky.lastIndex = 1)
&& reSticky.exec('bac')[0] === 'a'
&& (reStickyAnchored.lastIndex = 2)
&& reStickyAnchored.exec('cba') === null
&& RegExp('.', 's').exec('\n');
}],
'es.regexp.flags': function () {
Expand Down

0 comments on commit 67ed50d

Please sign in to comment.