-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't get SHIFT-SPACE to issue TAB (with karabiner elements) #1685
Comments
This came up a couple of times in the Discord server, but only seems to be related to KA360 Pro somehow, e.g. https://discord.com/channels/719497620560543766/1055137812481060884/1055137812481060884. There is a corresponding issue at KinesisCorporation/Adv360-Pro-ZMK#83. One thing I might try since those issues came up is disabling NKRO since that is one difference I noticed between usual ZMK setups and KA360. |
I tried disabling NKRO and it didn't help. To make sure I disabled properly, I am building locally using podman and changed that flag from 'y' to 'n' on both left and right keyboards in the local files. Any other ideas? |
I maintain the adv360 pro firmware, no idea why this is happening as all the keys and macro stuff is straight from ZMK main, there's only changes to the RGB code to add a couple unique effects, and minor tweaks to split connection handling. There's currently an open PR #1454 to add support for the ADV360 Pro in zmk main. @yanshay maybe try adding your macro to that firmware and trying again to see if it's the changes made to the zmk branch or a problem in the configuration files? |
@ReFil Happy to try, how do I do that? Can you guide me how to build a firmware based on that branch with my config? |
Apologies, i thought i typed out a guide but it must have not posted or something. It's easiest if you use the VSCode and Docker method detailed on the ZMK docs, you can follow this guide: https://zmk.dev/docs/development/setup Once you get to "Get source code" Use this link instead: https://github.com/ReFil/zmk.git Once this is complete you want to add your macro that doesnt work into the keymap for the new board definition. you want to go to the directory you cloned in the "Get source code step" go to zmk folder/app/boards/arm/adv360pro/adv360pro.keymap Do not just copy the keymap file from your config repo, the custom branch has some keys that are not compatible, that is why your compilation with podman didn't work. |
@ReFil Thanks, I'll try that. |
@ReFil I managed to build, I hope I did it correctly, the symptoms are the same. Shift + Mod-Morph on first press cause a shift to be sent (bug) and the second press isn't shifted (functions correctly). Does it mean it's a bug with zmk and on all keyboards? Or something to do with the Advantage Pro 360 zmk configurations? |
If it doesn't happen on the urob repo it sounds like there's a problem with the config files. I will continue to investigate |
@ReFil I made some progress here. |
But going back to the original event sequence, is the set of events the mod-morph generates is correct? |
I encountered this as well on a nice!nano in MacOS. Karabiner itself appears to reorder events for modifier keys when I have a mod-morph configured to send comma
Holding down left shift and pressing comma with
The shift up is reordered to come after the semicolon down, resulting in Once
|
I get the same problem. (I have a combo which sends 1 without shift and F1 with shift.) |
Same thing
When pressed with Alt, it sends Alt+C_BRI_UP. I am running it on Corne-isn Zen. Disabling NKRO didn't help. |
I am trying to get SPACE function as TAB when pressing SHIFT-SPACE.
I am using mod morph as follows:
However it issues a SHIFT-TAB and not a TAB.
This is what I see in karabiner event viewe:
I even tried adding
keep-mods = <0>;
and it didnt change a thing.so why is the mod being sent together with the key? it practically means I cant get to issue TAB using SHIFT-SPACE.
I just noticed this happens only on the first TAB, the following ones dont show the left_shift flag even though the SHIFT is still pressed
I also need to mention that the shift itself is coming from
&mt LSHIFT ESC
The text was updated successfully, but these errors were encountered: