-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(boards) Kinesis Advantage 360 pro #1454
Conversation
Removed deprecated macros, replace with correct Zephyr 3 implementation
I've merged just this PR into main branch, have successfully built firmwares and install them into my adv360. But LED indicators are not lit. I found some PRs which you issued on this PR list. |
LED indicators need a lot of custom RGB code to make them work, right now they're just set up as underglow defaulting to off. They won't work as intended for the foreseeable future. If you want the indicators to work properly you need to use the custom fork |
My setup that works with adv360-beta branch gives the following. I might just be doing something silly, I dunno. Any tips appreciated. devicetree error: /__w/zmk-config-adv360/zmk-config-adv360/config/adv360.keymap:56 (column 47): parse error: expected number or parenthesized expression |
The adv360-beta branch has features that are not present in zmk main, including behaviours. At a guess check the last layer and replace the &rgb_ug RGB_MEFS_CMD 5 with &none |
Ya, that got me further. Now I'm getting. |
You can't use a config branch for the adv360-beta branch with this. It simply won't work. Use this branch instead. The devicetree is all configured correctly https://github.com/PolarityWorks/zmk-config-adv360/tree/zmk-main |
very good. Thanks for your help. Good work BTW, and the keyboard is amazing IMO. |
Thanks for the support. It's much appreciated 😊 |
Isn't this PR missing from the left and right .defconfig files at least the following which are found in these files in https://github.com/KinesisCorporation/Adv360-Pro-ZMK ? CONFIG_USB_DEVICE_VID=0x29EA |
Any chance of us seeing this merged? |
howdy! Is this PR missing something to be able to be merged? |
Since the zephyr 3.2 update I need to rebase and bugfix before this can be merged. I'll work on it asap |
I didn't realize that, thank you ❤️ |
Zephyr 3.2 support and run pre-commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things here and there. The formatting definitely should be cleaned up for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a README to the board folder similar to the Glove80 one https://github.com/zmkfirmware/zmk/blob/main/app/boards/arm/glove80/readme.md ? I assume you will still be maintaining a fork with the extra features, like Glove80.
Just retested it because quite a few things changed through the review process and everything seems to still be working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, readme looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sticking with this. LGTM!
This PR adds support for the kinesis advantage 360 pro split, an nrf52840 based board
https://kinesis-ergo.com/keyboards/advantage360
I've tested this on real production hardware and everything works as expected, I'm not 100% sure about the metadata file though as I've never done one before
Board/Shield Check-list
.zmk.yml
metadata file added&pro_micro
used in favor of&pro_micro_d/a
if applicable (N/A).conf
file has optional extra features commented out