-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Zonemaster-LDNS version #1050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine, but travis fails.
This comes from the PR zonemaster/zonemaster-engine#1117 that removes some messages from the INFO level. But the test relies on such message to assert if IPv6 is disabled: Lines 211 to 219 in 8aacc32
|
When zonemaster/zonemaster#1090 is approved, merged and implemented there is a new message to look for. This PR could maybe wait for that to be done? |
The issue is not related to this PR but from how the code evolved in Zonemaster-Engine. All new PR will fail in Backend. To solve this we could either:
I'd like to go with proposition 3. However I haven't looked for a solution yet. |
Yes, I understand that.
The API only provides messages with level INFO and higher, and the message has been lowered to debug. I guess that providing a custom profile for the unit test would resolve it. Do you want me to fix that since I caused the problem by the PR in Engine? |
Good idea to update the testing profile. I've created #1051. |
Purpose
This exposes the Zonemaster-LDNS version via the API call
version_info
.Context
Addresses #790 (comment)
Changes
Update
version_info
to expose Zonemaster-LDNS version.Update API.md document.
Update t/test01.t to check that
version_info
returns a value for Zonemaster-LDNS.How to test this PR
Make a call to
version_info
and see that the Zonemaster-LDNS version is exposed.