Correct implementation, unit tests and unit tests data

zonemaster · Nov 20, 2023 · c027a61 · c027a61
1 parent b006d92
commit c027a61
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 64 deletions.
diff --git a/lib/Zonemaster/Engine/Test/DNSSEC.pm b/lib/Zonemaster/Engine/Test/DNSSEC.pm
@@ -2123,15 +2123,7 @@ sub dnssec03 {
         }
 
         foreach my $flag ( keys %nsec3_flags ) {
-            if ( $flag eq '0' ) {
-                push @results,
-                    info(
-                      DS03_NSEC3_OPT_OUT_DISABLED => {
-                        ns_list => join( q{;}, sort @{ $nsec3_flags{$flag} } )
-                      }
-                    );
-            }
-            elsif ( $flag eq '1' ) {
+            if ( $flag eq '1' ) {
                 # Note below that the Public Suffix List check is not yet implemented.
                 if ( $zone->name eq '.' or $zone->name->next_higher eq '.' ) {
                     push @results,
@@ -2153,11 +2145,20 @@ sub dnssec03 {
             else {
                 push @results,
                     info(
-                      DS03_UNASSIGNED_FLAG_USED => {
-                        ns_list => join( q{;}, sort @{ $nsec3_flags{$flag} } ),
-                        int => $flag
+                      DS03_NSEC3_OPT_OUT_DISABLED => {
+                        ns_list => join( q{;}, sort @{ $nsec3_flags{$flag} } )
                       }
                     );
+
+                if ( $flag ne '0' ) {
+                    push @results,
+                        info(
+                          DS03_UNASSIGNED_FLAG_USED => {
+                            ns_list => join( q{;}, sort @{ $nsec3_flags{$flag} } ),
+                            int => $flag
+                          }
+                        );
+                }
             }
         }
     }