Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check MANIFEST when PR is created #902

Closed
matsduf opened this issue May 17, 2021 · 1 comment · Fixed by #903
Closed

Check MANIFEST when PR is created #902

matsduf opened this issue May 17, 2021 · 1 comment · Fixed by #903
Assignees
@mattias-p
Labels
T-Feature Type: New feature in software or test case description
Milestone
v2023.1

Comments

@matsduf
Copy link
Contributor

matsduf commented May 17, 2021

Whenever a file is added or removed MANIFEST or MANIFEST.SKIP must be updated. This is something that is often missed by all developers.

Add a test so that Travis/Github action complains if MANIFEST* is not correct, comparable to make distcheck.
@matsduf matsduf added this to the v2021.2 milestone May 17, 2021
@matsduf matsduf added the T-Feature Type: New feature in software or test case description label May 17, 2021
@matsduf matsduf mentioned this issue May 17, 2021
Merged
@mattias-p mattias-p self-assigned this May 17, 2021
@mattias-p mattias-p mentioned this issue May 17, 2021
Merged
This was referenced May 20, 2021
Open
Open
Open
@mattias-p mattias-p mentioned this issue Jun 1, 2021
Merged
@matsduf matsduf modified the milestones: v2021.2, v2022.1 Dec 8, 2021
@matsduf matsduf modified the milestones: v2022.1, v2022.2 May 21, 2022
@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@tgreenx
Copy link
Contributor

tgreenx commented May 16, 2023

Fixed by #903

@tgreenx tgreenx closed this as completed May 16, 2023
@tgreenx tgreenx linked a pull request May 16, 2023 that will close this issue
Check manifest #903
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattias-p mattias-p

Labels
T-Feature Type: New feature in software or test case description
Projects
None yet
Milestone
v2023.1
Development

Successfully merging a pull request may close this issue.

Check manifest mattias-p/zonemaster-engine
3 participants
@mattias-p @matsduf @tgreenx