You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only one message tag not tested for the moment (should be added on a later PR).
Updated 2021-05-17:
How to test this PR
Read the test case specification for DNSSEC16 and verify that the implementation correctly reports issues and non-issues on selected zones to cover as many message tags as possible.
@matsduf implementation "finished" (no translation yet). We have to add new unit tests when we will find broken zone or when we will be able to configure these broken zone.
@matsduf Can you have a look ? I will not add more unit tests (only one message tage is not covered for the moment, I made some modification on Bind to prevent some checks that allow to load broken zones). I start to work on dnssec17. If we can merge dnssec16 before, it will be easier for the merge.
@matsduf Can you test again with dnssec16-delete-cds.zft-root.rd.nic.fr broken zone ? I do not understand why you have not the DS16_DELETE_CDS message tag.
@matsduf Can you test again with dnssec16-delete-cds.zft-root.rd.nic.fr broken zone ? I do not understand why you have not the DS16_DELETE_CDS message tag.
# zonemaster-cli --no-ipv6 --show_testcase --test DNSSEC dnssec16-delete-cds.zft-root.rd.nic.fr --locale en_US.UTF-8
Seconds Level Testcase Message
======= ========= ============== =======
4.93 WARNING DNSSEC05 The DNSKEY with tag 64275 uses an algorithm number 5 (RSA/SHA1) which is not recommended to be used.
4.93 WARNING DNSSEC05 The DNSKEY with tag 37774 uses an algorithm number 5 (RSA/SHA1) which is not recommended to be used.
4.94 WARNING DNSSEC05 The DNSKEY with tag 37774 uses an algorithm number 5 (RSA/SHA1) which is not recommended to be used.
4.94 WARNING DNSSEC05 The DNSKEY with tag 64275 uses an algorithm number 5 (RSA/SHA1) which is not recommended to be used.
5.23 WARNING DNSSEC14 DNSKEY with tag 64275 and using algorithm 5 (RSA/SHA1) has a size (1024) smaller than the recommended one (2048).
5.40 NOTICE DNSSEC15 CDS RRset is found on nameservers that resolve to IP addresses (145.239.76.199;145.239.76.201), but no CDNSKEY RRset.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated 2021-05-17:
How to test this PR
Read the test case specification for DNSSEC16 and verify that the implementation correctly reports issues and non-issues on selected zones to cover as many message tags as possible.