PoC: Send queries with EDNS option NSID set and retrieve the value if available #1133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is about validating that Zonemaster can retrieve and display NSID values from nameservers if available.
Question
Currently this PR sets the EDNS option NSID to all queries. Should this option be sent only to nameservers that support EDNS (look for the results from Nameserver02)?
Todo
Context
Addresses #178 and follow-up on zonemaster/zonemaster-ldns#151
Changes
ns/ip
tuple resulting inns/ip/nsid
How to test this PR
This requires libldns >= 1.8.2 and Zonemaster-LDNS from zonemaster/zonemaster-ldns#151
See the tuple
nsp.dnsnode.net/2a01:3f1:3032::53/s4.bnx
which is made of the nameserver name, the nameserver IP and the nameserver NSID.If there is no NSID, the output would be unchanged: