Expand DNAME support #170
Merged
Expand DNAME support #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow access to DNAME RR - Add unitary test
tgreenx
added
S-PRforIssue
tgreenx
requested review from
matsduf,
vlevigneron,
hannaeko,
a user and
marc-vanderwal
marc-vanderwal
previously approved these changes
Mar 9, 2023
matsduf
reviewed
Mar 9, 2023
lib/Zonemaster/LDNS/RR/DNAME.pm
Outdated
| =cut | ||
| =item dname() | ||
|
|
||
| Returns the delegation name. |
There was a problem hiding this comment.
It is clearer to say the RDATA of a DNAME record.
ghost
reviewed
Mar 13, 2023
| MODULE = Zonemaster::LDNS PACKAGE = Zonemaster::LDNS::RR::DNAME PREFIX=rr_dname_ | ||
|
|
||
| char * | ||
| rr_dname_dname(obj) |
There was a problem hiding this comment.
suggestion: name the method target instead, as it seems to be the given name of the RDATA RFC 6672 section 2.
There was a problem hiding this comment.
Considering how we use such methods in Engine, I would prefer to keep them this way. However I have clarified the documentation to account for that technicality. Is that fine for you?
There was a problem hiding this comment.
Oh I understand. This is totally fine then.
tgreenx
removed
the
S-PRforIssue
- Clarify documentation of method 'Zonemaster::LDNS::RR::DNAME::dname()'
ghost
approved these changes
Mar 14, 2023
matsduf
reviewed
Mar 14, 2023
| =cut | ||
| =item dname() | ||
|
|
||
| Returns the delegation name, i.e. the <target> field from the RDATA of a DNAME record. |
There was a problem hiding this comment.
The RDATA only consists of the target so "from the RDATA" sounds strange. There is only one field to fetch. Maybe
Returns the delegation name, i.e. the DNAME record target (RDATA).
matsduf
approved these changes
Mar 14, 2023
1 task
2 tasks
tgreenx
added
V-Major
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR expands the functionality of DNAME resource records by giving access to its RDATA.
Context
Necessary for zonemaster/zonemaster-engine#568
Relates to zonemaster/zonemaster#1075 and zonemaster/zonemaster#472
Changes
How to test this PR
Unit tests should pass