Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #26 #27

Merged
merged 3 commits into from
Dec 19, 2017
Merged

Fixed issue #26 #27

merged 3 commits into from
Dec 19, 2017

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Dec 6, 2017

Fixed so rr.t so it matches current Internet and changed so that tests that depend on network are not run by default (issue #26).

.travis.yml is updated so that network tests are always run.

Copy link
Member

@mattias-p mattias-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However the neither the old environment variable nor the new one is documented anywhere. This could be resolved by adding a section about testing to README.md that mentions the new environment variable.

@sandoche2k sandoche2k added this to the 2017.4 milestone Dec 19, 2017
Copy link
Contributor

@vlevigneron vlevigneron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me.

@matsduf matsduf merged commit f08fe5c into zonemaster:develop Dec 19, 2017
@matsduf matsduf deleted the fix-unit-tests branch December 19, 2017 15:11
@ghost ghost mentioned this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants