Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying which OpenSSL library to use #97

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

mattias-p
Copy link
Member

Adds the --prefix-openssl option to Makefile.PL.

This makes it possible to enable Ed25519 support in Zonemaster on systems with older versions of OpenSSL without disturbing applications that use the system-provided OpenSSL.

The purpose is to support ED25519 signatures on CentOS 7.
@mattias-p mattias-p added this to the v2020.1 milestone Nov 22, 2019
Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message says "The purpose is to support ED25519 signatures on CentOS 7." Has this been tested with other OSs than CentOS 7?

@mattias-p
Copy link
Member Author

Yes, on Debian 8 as well.

@mattias-p
Copy link
Member Author

@matsduf @sandoche2k I used the --prefix-openssl option introduced here to get algo 15 working on CentOS 7 and Debian 8.

Copy link
Contributor

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me the change looks good.

The changed Makefile.PL has been used for FreeBSD, without the option, and it works as it should.

@mattias-p mattias-p merged commit 202c433 into zonemaster:develop Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants