Updated build instructions #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
I suggest a different approach based on |
zonemaster/zonemaster-ldns#158 will not replace this PR, but if that is merged then it will be enough to run |
matsduf
force-pushed
the
update-build-instructions
branch
from
718ce02
to
561276b
Compare
|
@pnax, please review. |
ghost
previously approved these changes
Nov 3, 2022
| @@ -36,14 +36,15 @@ the `develop` branch and that your clone is up-to-date. | |||
| git fetch --all | |||
| git branch | |||
|
|
|||
| For Zonemaster-LDNS only - reset submodule (LDNS): | |||
There was a problem hiding this comment.
For information, it's more an update of the submodule than a reset (the submodule is checked out to the right commit).
There was a problem hiding this comment.
Corrected. Please re-review.
ghost
approved these changes
Nov 7, 2022
hannaeko
added
the
S-ReleaseTested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This applies for the build instructions for Zonemaster-LDNS. That repository has a submodule to LDNS. If the submodule is checked out and the version is changed in the branch checked out, then then submodule must be updated. If changing between branches with different version of the submodule, then the submodule must also be updated.
The changes in this PR assumes that zonemaster/zonemaster-ldns#158 is merged.
How to test this PR
Review and test using the documents.