api: Update add_realm_filter to support url_template. #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
PIG208
force-pushed
the
url-template
branch
2 times, most recently
from
5684e7c
to
62723c5
Compare
This adds support to adding linkifiers with the new URL template syntax. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
|
I'm not sure it's particularly coherent to have the same function pass different formats, but ultimately this is an administrative API and the user will likely be looking at the Zulip settings UI when using it, so I think it's fine in practice. (And better than, say, writing code to convert a URL template into a format string). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to adding linkifiers with the new URL template syntax.
This PR relies on zulip/zulip#23125 to determine the feature level that changes the endpoint.