-
-
Notifications
You must be signed in to change notification settings - Fork 643
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
expo: Migrate from "Unimodules" to "Expo modules", as requested
Done by mostly following the changes to Expo's templates/expo-template-bare-minimum/ in expo/expo@9781212eb. Expo's description of the new infrastructure is at https://blog.expo.dev/whats-new-in-expo-modules-infrastructure-7a7cdda81ebc . They gave a migration guide that suggested making changes similar to these, but it didn't end up helping us understand why they were the right changes to make or what would happen if we made them. That guide is at https://github.com/expo/fyi/blob/main/expo-modules-migration.md . We've cleared up some of the mystery; see #5203 (comment) and previous commits in this series. In this commit: - (Mostly follow expo/expo@9781212eb, as mentioned) - Also, upgrade all our `expo-*` direct dependencies so that they work with the new system. (We upgrade them minimally, to minimize having to think about possible unrelated breaking changes right now.) Details at #5203 (comment) . - Remove android/app/src/main/java/com/zulipmobile/generated/BasePackageList.java, since its only import was removed. (Expo didn't have this file in version control, and the migration guide didn't mention the file.) - The Expo commit assumes that our project has done special setup for `expo-updates`, `expo-constants`, and `expo-splash-screen`. It makes changes to that setup, which we ignore since we don't use any of those. If we need them in the future, we'll just look up their current setup instructions at the time. - Don't add an empty Swift file. The migration guide says, "A blank Swift file must be created for native modules with Swift files to work correctly." With `find node_modules | grep .swift` in our project, I see that expo-modules-core and expo-web-browser have many Swift files in them, and I don't have any problems building or running the app without an empty Swift file of our own. The template app doesn't add one either. - Don't add a Podfile.properties.json file. Like the changes in expo/expo@dbd384b22, this would have us put certain config values in some new Expo-branded variables. We're happy keeping the values inline. - Update our value for `transformIgnorePatterns` in the Jest config, following an error when running Jest. - Looks like some sub-dependency at its updated version wants to cause different output for `generate-webview-js`. Examine that output (looks OK), and commit. Fixes: #5133
- Loading branch information
1 parent
573697c
commit aedc8b8
Showing
17 changed files
with
1,510 additions
and
1,036 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
android/app/src/main/java/com/zulipmobile/generated/BasePackageList.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.