-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose box obscured by keyboard on long message, in stream view #3369
Comments
Thanks @armaanahluwalia for this report! Very interesting. To highlight one detail: this specifically happens when narrowed to a whole stream -- it doesn't happen when narrowed to a topic. To describe here in words the exact symptom: when you type a long (draft) message, the compose box grows to make room... and in the video, it eventually grows to try to use some space that's hidden by the keyboard. Some further observations in the video:
Further notes:
|
Oh also -- this symptom is reminiscent of #3273 "Keyboard overlaps the compose box on iOS". That one was fixed in 23.0.109, but the history may be a clue for what to look into. |
(I went and filed #3370 for the blank white band.) |
Some discussion on a duplicate issue, #3414. One direction to fix this would be to limit the compose box's height. But this shouldn't be a small fixed limit like 6 lines; see discussion on #3049. Instead it should fill the space available. See @borisyankov 's comment on #3414 about how that would ideally work. Also @jainkuniya points out that the fact this happens only on a stream narrow means it only happens when the topic input is present. That's probably a clue. The compose box's layout already works just fine when there's no topic input; if we can make it work equally well when there is, that solves the problem. |
See #3579 for another report, with a nice screenshot demonstrating the issue. |
Remove scroll view from input wrapper (which was added in zulip#3595). This fixed zulip#3614. Also just checked it works fine on Android as well. So basically zulip#3595 was not a completely right solution for zulip#3369. Now inputs are wrapped with simple view, which is self aligned as vertically center. ComposeMenu and SendButton are self aligned as vertically end. And wrapper of all this three has justifyContent as space-between, which makes them spread whole over horizontal space available. This removes alignItems: 'flex-end' from `composeBox`, which was pushing input to vertically bottom, idealy it should be at vertically center. Fixes: zulip#3614
When replying to a message in the stream view, if the message you’re typing is longer than a certain line length, the message gets cut off.
This makes drafting long messages extremely difficult. See this video for a reproduction.
The text was updated successfully, but these errors were encountered: