Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'SafeAreaView' through the app #3067

Closed
wants to merge 10 commits into from
Closed

Use 'SafeAreaView' through the app #3067

wants to merge 10 commits into from

Commits on Sep 23, 2020

  1. safeAreaView: Ensure MainScreenWithTabs is aligned 

    Makes sure our main tabs are aligned properly with the edges of the screen on iOS.

More about how safe areas work on iOS:
https://developer.apple.com/documentation/uikit/uiview/positioning_content_relative_to_the_safe_area

About the React Native-specific component:
https://facebook.github.io/react-native/docs/safeareaview
    @borisyankov @chrisbobbe
    borisyankov authored and chrisbobbe committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    19f367a View commit details
    Browse the repository at this point in the history

  2. screen: Use SafeAreaView in Screen component 

    Instead of using `react-native-safe-area` and getting the inset
values from the `session` state, use `SafeAreaView` witch is a
component coming with React Native.
    @borisyankov @chrisbobbe
    borisyankov authored and chrisbobbe committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    deba961 View commit details
    Browse the repository at this point in the history

  3. composebox: Use SafeAreaView in ComposeBox 

    Fixes zulip#3066

Previous approach almost worked correctly, but there was one
case it didn't - when the keyboard did pop on an iPhone, the
bottom space was sill there, though it shouldn't, as the keyboard
is located over the `Home Indicator`.
    @borisyankov @chrisbobbe
    borisyankov authored and chrisbobbe committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    3a01a26 View commit details
    Browse the repository at this point in the history

  4. Use SafeAreaView in ChatScreen 

    All 'screen'-type components need a `SafeAreaView` to make sure
the offsets from the edges are correct. This makes sure we do
that fot the `ChatScreen` component.
    @borisyankov @chrisbobbe
    borisyankov authored and chrisbobbe committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    13f1ea8 View commit details
    Browse the repository at this point in the history

  5. safeArea: Do not track safea area insets 

    We no longer need `react-native-safe-area` so stop using it to
track the changes to the safe area insets (we are using `SafeAreaView`)
    @borisyankov @chrisbobbe
    borisyankov authored and chrisbobbe committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    57a52ca View commit details
    Browse the repository at this point in the history

  6. satusbar: Do not use safe area insets in ZulipStatusBar 

    ...
    @borisyankov @chrisbobbe
    borisyankov authored and chrisbobbe committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    838136d View commit details
    Browse the repository at this point in the history

  7. sessionReducers: Remove safeAreaInsets 

    We no longer track `safeAreaInsets` data so remove i from the reducer.
    @borisyankov @chrisbobbe
    borisyankov authored and chrisbobbe committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    bb5d104 View commit details
    Browse the repository at this point in the history

  8. cleanup: Remove actions and types about safe area insets 

    No longer used and needed. Remove completely from the codebase.
    @borisyankov @chrisbobbe
    borisyankov authored and chrisbobbe committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    4e9ad92 View commit details
    Browse the repository at this point in the history

  9. cleanup: Remove 'react-native-safe-area' 

    Now, completely unused, remove the 'react-native-safe-area' package.
    @borisyankov @chrisbobbe
    borisyankov authored and chrisbobbe committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    90a39b3 View commit details
    Browse the repository at this point in the history

  10. safeAreaView: Use SafeAreaView in LightboxScreen

    @borisyankov @chrisbobbe
    borisyankov authored and chrisbobbe committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    96981eb View commit details
    Browse the repository at this point in the history