Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help: Document new UI for testing mobile push notifications. #28076

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

alya
Copy link
Contributor

@alya alya commented Dec 7, 2023

Getting the PR below merged and out to users is a blocker for deploying this change:

Current page: https://zulip.com/help/mobile-notifications#testing-mobile-notifications

Updated:

Screenshot 2023-12-07 at 5 10 59 PM
Screenshot 2023-12-07 at 5 11 06 PM

@alya alya added the help center review Help center docs review needed. label Dec 7, 2023
@alya
Copy link
Contributor Author

alya commented Dec 7, 2023

@chrisbobbe Any feedback on this one?

@chrisbobbe
Copy link
Contributor

LGTM except for "loging out" in the "Tip" at the bottom.

@alya
Copy link
Contributor Author

alya commented Dec 7, 2023

Oh, I just realized that we probably need to keep the old instructions for pre-8.0 servers.

@alya
Copy link
Contributor Author

alya commented Dec 8, 2023

Ok, here's another attempt. @chrisbobbe what do you think?

Copy link
Contributor

@chrisbobbe chrisbobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One small comment below, on something I missed in my first review.

help/mobile-notifications.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Bobbe <cbobbe@zulip.com>
@alya alya added the integration review Added by maintainers when a PR may be ready for integration. label Dec 11, 2023
@timabbott timabbott merged commit e525160 into zulip:main Dec 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help center review Help center docs review needed. integration review Added by maintainers when a PR may be ready for integration. size: L
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants