Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for driver presets #1071

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Add support for driver presets #1071

merged 6 commits into from
Oct 17, 2023

Conversation

raman325
Copy link
Collaborator

@raman325 raman325 commented Oct 17, 2023 •
edited
Loading

in this change, we expect driverPresets to be a potential key that is in the config passed to the server with a list of presets.

@raman325 raman325 changed the title Add support for zwave presets Add support for driver presets Oct 17, 2023
AlCalzone
AlCalzone requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Discord, I'd do this a bit differently

src/bin/server.ts Outdated Show resolved Hide resolved
src/bin/server.ts Outdated Show resolved Hide resolved
@raman325 raman325 merged commit c2c69b9 into master Oct 17, 2023
1 check passed
@raman325 raman325 deleted the presets branch October 17, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raman325 @AlCalzone