Add driver command to update log config #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raman325
changed the title
raman325
changed the title
This was referenced Feb 15, 2021
MartinHjelmare
requested changes
Feb 16, 2021
raman325
force-pushed
the
update_log_config
branch
3 times, most recently
from
f9ad0d0
to
c2a8905
Compare
raman325
changed the title
|
I will rebase once #118 is merged |
|
#118 is merged. 👍 |
raman325
force-pushed
the
update_log_config
branch
from
c2a8905
to
14319c1
Compare
|
I'd like some TS/JS eyes on this PR. |
Do we want to bump the server version now, or wait until this is merged? Given that we can't currently get the current log config (that will come in the next |
|
We can do a release now of the server and have this PR go in a later release. |
balloob
reviewed
Feb 17, 2021
balloob
reviewed
Feb 17, 2021
balloob
reviewed
Feb 17, 2021
|
Since we are on the latest version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #115 and zwave-js/node-zwave-js#1754. This will allow us to add support to update the log configuration in the Python library and then expose a service in Home Assistant to update the log levels without having to restart the server.
The version bump is a breaking change to the add-on - updating the add-on would depend on home-assistant/core#46355 in order for
zwave_jsthermostats in Home Assistant to continue to function.Resolves #115