Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping Button in Network Graph Obstructed by Bottom Banner #3890

Closed
3 tasks done
The00Dustin opened this issue Sep 13, 2024 · 6 comments · Fixed by #3896
Closed
3 tasks done

Ping Button in Network Graph Obstructed by Bottom Banner #3890

The00Dustin opened this issue Sep 13, 2024 · 6 comments · Fixed by #3896
Labels
bug Something isn't working

Comments

@The00Dustin
Copy link
Contributor

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Home Assistant Add-on

Z-Wave JS UI version

9.18.1

ZwaveJS version

13.2.0

Describe the bug

The ping button (and possibly others) are obstructed by the bottom banner when a desktop browser is sized small enough to cause the node properties section to be narrow enough for the buttons to wrap. Here is a screenshot:
Screenshot

To Reproduce

Reduce the size of your desktop browser enough to move the ping button to a separate row from other buttons.

Expected behavior

The bottom of the node properties section should sit above the banner so that everything contained within it can be seen..

Additional context

No response

@The00Dustin The00Dustin added the bug Something isn't working label Sep 13, 2024
@The00Dustin
Copy link
Contributor Author

To elaborate a bit in case this isn't as easily reproducible as I expect it to be: The browser in this screenshot is Safari on macOS. Also, ssince the scrollbar isn't visible, I did confirm the part of the page with the legend and graph was scrolled all the way down for the included screenshot..

@kpine
Copy link
Contributor

kpine commented Sep 13, 2024

You can move the window. #3191

Maybe there needs to be some hint you can do so (cursor change, handle bar?).

@The00Dustin
Copy link
Contributor Author

Sure enough. I'm not sure how that would be made obvious, I guess if the mouse cursor could be changed that might be obvious enough, but it still seems odd to have any part of it behind anything by default when that can be avoided (the whole thing will fit when I move it).

@robertsLando
Copy link
Member

@The00Dustin Could we agree to change the cursor as a fix?

@The00Dustin
Copy link
Contributor Author

I just tried on mobile, and I don't think this would happen on mobile (at least not with the HAOS add-on), so yes, I think that's a fair fix.

@robertsLando
Copy link
Member

I also added a method to position the view in the best place based on window dimensions so you should not move it anymore :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants