Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): use inverted checkbox to clarify settings #3823

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

robertsLando
Copy link
Member

No description provided.

@robertsLando
Copy link
Member Author

cc @AlCalzone

@coveralls
Copy link

coveralls commented Jul 22, 2024

Pull Request Test Coverage Report for Build 10041332107

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.029%

Totals Coverage Status
Change from base Build 10038693375: 0.0%
Covered Lines: 3899
Relevant Lines: 19721

💛 - Coveralls

@AlCalzone
Copy link
Member

AlCalzone commented Jul 22, 2024

There are a few more:
grafik
(also why is this a checkbox when all others are a toggle?)

grafik

grafik

On second thought, maybe the checkboxes are fine, but the toggles are confusing.

@robertsLando
Copy link
Member Author

So should I only change the dns discovery one?

@AlCalzone
Copy link
Member

I guess, yeah

@robertsLando robertsLando merged commit 7b48ad9 into master Jul 22, 2024
4 of 8 checks passed
@robertsLando robertsLando deleted the inverted-checkbox branch July 22, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants