Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package] Mark Gmail as recommended to remove #138

Merged
merged 1 commit into from
Mar 17, 2022
Merged

[Package] Mark Gmail as recommended to remove #138

merged 1 commit into from
Mar 17, 2022

Conversation

genodeftest
Copy link
Contributor

Gmail is not needed for anything but e-mails which can also be done using a different app or any web browser on the smartphone or any other device.

Gmail is not needed for anything but e-mails which can also be done using a different app or any web browser on the smartphone or any other device.
@KarlRamstedt
Copy link
Contributor

This might be one of those packages that would confuse/annoy too many users if removed by default (Recommended).

@genodeftest genodeftest reopened this Feb 18, 2022
@genodeftest
Copy link
Contributor Author

genodeftest commented Feb 18, 2022

(I closed this PR by accident, thinking that it was also part of your PR)

This might be one of those packages that would confuse/annoy too many users if removed by default (Recommended).

On the other hand, this is one of the first packages many users (who don't want to use Gmail) would remove.
Following your logic, any default web browser (e.g. Chrome) should also be kept on the device (when using Recommended) because it would confuse many users to have no web browser at all. If UAD keeps following this logic, I think I should create a separate PR to move all the com.qti.* and com.qualcomm.* system packages from Recommended at least to Advanced or even Expert.

@KarlRamstedt
Copy link
Contributor

Oh, I'm not saying that I think Gmail should be in Advanced, I'm saying I'm not sure.

My uncertainty is based on what @0x192 said regarding a default OEM Gallery app:

I prefer not put default Gallery app in the Recommended list. Advanced is better suited. [...] people won't understand if we keep it in Recommended.

You do make a good point; consistency is important. This is a tough discussion to decide on, but personally I'd lean toward removal(Recommended) for anything that is available through the Play Store and isn't functionally important (like the default Keyboard app). Let's see what @0x192 says on the topic.

@0x192
Copy link
Owner

0x192 commented Mar 17, 2022

I'd lean toward removal(Recommended) for anything that is available through the Play Store and isn't functionally important (like the default Keyboard app)

I totally agree and it's better, from a privacy and security point of view, to install the Play Store version of a system app.

In addition, removing Gmail does not cause any data loss.

@0x192 0x192 merged commit 2b0f424 into 0x192:main Mar 17, 2022
@genodeftest genodeftest deleted the patch-1 branch March 17, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants