Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Some Safe apps cannot be loaded in the desktop app #2672

Closed
mmv08 opened this issue Aug 24, 2021 · 2 comments · Fixed by #3273
Closed

Some Safe apps cannot be loaded in the desktop app #2672

mmv08 opened this issue Aug 24, 2021 · 2 comments · Fixed by #3273
Assignees
Labels
Bug 🐛 Something isn't working effort-mid Medium-effort issues Research 🔬

Comments

@mmv08
Copy link
Member

mmv08 commented Aug 24, 2021

Description

Some safe apps use HTTP headers such as Content-Security-Policy to let the website being loaded as an iframe for specific websites. This strategy works well for the interface hosted on gnosis-safe.io but doesn't for the desktop app.

We also got a request for easy detection if the app is loaded as a safe app that doesn't require loading the SDK - in the web version, one can use desktop.referrer, but not on the desktop. It could be done with the query params.

Affected apps:
Zerion, 1inch, furucombo

Environment

Latest desktop app

Steps to reproduce

  1. Try to load Zerion safe app in the desktop app

Expected result

To be evaluated by the team

Obtained result

The app doesn't load

@katspaugh katspaugh added the Question❓ Issue with questions to clarify label Aug 25, 2021
@katspaugh katspaugh added Research 🔬 effort-mid Medium-effort issues and removed Question❓ Issue with questions to clarify labels Sep 16, 2021
@katspaugh katspaugh added the Bug 🐛 Something isn't working label Sep 22, 2021
@mmv08 mmv08 self-assigned this Nov 29, 2021
@mmv08
Copy link
Member Author

mmv08 commented Nov 29, 2021

Some safe apps use HTTP headers such as X-Frame-Ancestors to let the website being loaded as an iframe for specific websites. This strategy works well for the interface hosted on gnosis-safe.io but doesn't for the desktop app.

To fix this I suggest letting the desktop app know about such apps so it can hide them, and introducing a new boolean flag on the backend: restrictsAccessBySource

@JagoFigueroa
Copy link

JagoFigueroa commented Jan 13, 2022

Hola guys! Unfortunately I am having a few issues when testing this PR with this build of the app that @dasanra created for me: https://github.com/gnosis/safe-react/actions/runs/1693347662

I can still see the Zerion app in the list of apps and a few others that do not open and I think should be hidden as well after this fix (I checked on mainnet):

-DODO
-1inch Network (mainnet)
-furucombo
-StakeWise
-WrappedPunks
-yearnFinance

Also apps like Uniswap, sushi or other token swapping apps in general do not seem to fetch the safe asset balance making them pretty much useless (although this looks like something to tackle in a separate ticket).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working effort-mid Medium-effort issues Research 🔬
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants