-
Notifications
You must be signed in to change notification settings - Fork 363
Feature: Retrieve Safe Apps only guaranteed to work on the current client #3273
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deployment links
|
E2E Tests Failed Failed tests:
|
Pull Request Test Coverage Report for Build 1697629199
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merge branch 'dev' of github.com:gnosis/safe-react into feature/pass-client-url-when-retrieving-safe-apps
Screen.Recording.2022-01-14.at.15.22.40.movThe issue reported by @JagoFigueroa in the original issue was because the build used prod backend where correct accessControls are not set yet. When using staging endpoints it works perfectly (check video) |
Thank you @mikheevm ! I think it's more than fair to close this ticket then ;) |
What it solves
Resolves #2672 where apps limited access to embedding it as an iframe to specific origins
How this PR fixes it
So now, for
GET /safe-apps
, there's aclientUrl
param available on the client gateway and config service. It takes a hostname with a protocol, and the returned apps are ensured to work on this client.How to test it