This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Feature: desktop localstorage migration #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient (#3273) * pass current origin to the safe apps endpoint, add access controls to types * pass current origin to the safe apps endpoint, add access controls to types * update deps * cmon javascript build ples * fix param casing, update sdk * Update build desktop app github action Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
E2E Tests Passed ✅ |
|
Desktop build with latest changes |
|
Testing finished! Thank you guys for helping and the quick action in creating the builds ;) |
dasanra
approved these changes
Feb 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #3379
Cherry-picks #2672
How this PR fixes it
It turned out that we don't need a migration script, but we had to change
productNamein package.json to match the old name, so it uses the same cache folderHow to test it
distfolder and check that all the content from an old app is thereDo I merge it to the
electronbranch or we should create a new one for the release?