fix: transaction remain pending

[iamacook]

What it solves

Resolves #3440

How this PR fixes it

Transactions now return the transactionHash from the receipt. After 50 blocks have been mined without successfuly execution, it throws triggering the onError where the pending status is removed.

onComplete (for on-chain) transactions now occurs upon receiving the transaction hash as we save the txHash for the pending transaction. (Immediately executing transactions have no txId and need to be proposed in order to save { [txId]: txHash } in the pending store).

How to test it

1 Create a transaction (with low gas) and then cancel it via a (high gas) cancellation in MM.
2 After 15-30 mins, observe a notification about unsuccessful pend and a console error about the transaction not being mined within 50 blocks.

Screenshots

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[coveralls]

Pull Request Test Coverage Report for Build 1875604863

• 4 of 16 (25.0%) changed or added relevant lines in 4 files are covered.
• 55 unchanged lines in 1 file lost coverage.
• Overall coverage remained the same at 33.613%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/logic/safe/store/reducer/pendingTransactions.ts	1	2	50.0%
src/logic/safe/store/actions/createTransaction.ts	0	11	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/routes/safe/components/Apps/components/AppFrame.tsx	55	0%

Totals
Change from base Build 1859711200:	0.0%
Covered Lines:	3238
Relevant Lines:	8624

---

💛 - Coveralls

[github-actions]

Deployment links

🟠 Rinkeby	⚪ Mainnet	🟣 Polygon	🟡 BSC	⚫ Arbitrum	🟢 Gnosis Chain

[katspaugh]

Then you probably don't need this at all.
Just replacing .once('transactionHash') with .then(({ transactionHash }) => transactionHash) will already make it wait for the final error (or success).

[iamacook]

We're still investigating this as it takes 50 blocks before an error is emitted, so it's really time-consuming to debug. We're getting there though.

[katspaugh]

Should be faster on an L2 like Aurora (and free, too).

[github-actions]

E2E Tests Passed ✅
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1875642099

[iamacook]

We are going to split this into a second ticket as we have unveiled a deeper issue that is explained here.

[katspaugh]

So the fix, as I understood, is that it now correctly waits for the PromiEvent to finish, so that potential post-hash errors aren't ignored like before?

And it's still fast because you call onComplete as soon as the hash is there?

[iamacook]

So the fix, as I understood, is that it now correctly waits for the PromiEvent to finish, so that potential post-hash errors aren't ignored like before?

And it's still fast because you call onComplete as soon as the hash is there?

Exactly

[francovenica]

Noted the comment about the pending tx remaining there forever. I'll check that in that other ticket created for it

Ok, so I tried this twice.
The first time I created a random tx with low gas and as soon as the tx was put in queue in pending status I rejected it in the MM extension. After 13 mins the notification of "Transaction still pending" showed up, but the error didn't mentioned nothing about 50 blocks. After 30 mins I just refreshed the page and reloaded the Queue tab until the Pending tx disappeared

The 2nd time I waited for a bit before submitting the cancelation (I wanted the tx to be indexed by the block explorer first, but it never was). I cancelled the tx in the MM extension and waited for over 30 mins and no error notification popped up at all.

Both rejections, after more than 1 hour still show as "pending of indexation" in the block explorer although they are shown as executed in the MM extension, idk what is up with that
The cancelations in order:
https://rinkeby.etherscan.io/tx/0x9f8361f4221340cf017239faac25ce83fabaa11773f4b6166976b51275038ccd
https://rinkeby.etherscan.io/tx/0xc2379d047e4094710a54e0995741ffdf80a24c14737ad282a97663c9ca2afba1

I'll try one more time tomorrow to see if I get the 50 blocks error message in the console

[iamacook]

The 50 block error may only show in the developer environment. I'm not sure. The notification is shown when the error would appear in the console - it's triggered by the it.

[usame-algan]

LGTM

[francovenica]

Passing this one given the comment after my report. Also since the ticket #3531 was created to address the issue with the pending status I'll recheck everything when that ticket is ready