-
Notifications
You must be signed in to change notification settings - Fork 363
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
fc00e7c
to
76b8ffa
Compare
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 2076252016
💛 - Coveralls |
cypress.json
Outdated
@@ -0,0 +1,3 @@ | |||
{ | |||
"baseUrl": "https://safe-team.dev.gnosisdev.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should include /app
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are redirected with or without /app
. I've changed it in the last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It redirects, but React Router will warning about it.
"prepare": "husky install" | ||
"prepare": "husky install", | ||
"cypress:open": "cypress open", | ||
"cypress:run": "cypress run" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I get it right that it will run on safe-team.dev.gnosisdev.com
?
How do I launch it on localhost?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can change baseUrl in cypress.json to localhost:3000/app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the cy.visit("/") are going to prepend baseUrl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we change it to localhost then. And merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the baseUrl
to test against localhost
bb099b0
to
25d5274
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What it solves
Adds Cypress to the repo
How to test it
Run
yarn cypress:open
to display the test suitScreenshots