Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Chore: add Cypress #3745

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Chore: add Cypress #3745

merged 3 commits into from
Apr 1, 2022

Conversation

DiogoSoaress
Copy link
Member

What it solves

Adds Cypress to the repo

How to test it

Run yarn cypress:open to display the test suit

Screenshots

Screen Shot 2022-03-31 at 15 35 32

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Mar 31, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh changed the title feature: add cypress Chore: add Cypress Mar 31, 2022
@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@coveralls
Copy link

coveralls commented Mar 31, 2022

Pull Request Test Coverage Report for Build 2076252016

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 55 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 36.039%

Files with Coverage Reduction New Missed Lines %
src/routes/safe/components/Apps/components/AppFrame.tsx 55 0%
Totals Coverage Status
Change from base Build 2069109004: -0.003%
Covered Lines: 3517
Relevant Lines: 8867

💛 - Coveralls

cypress.json Outdated
@@ -0,0 +1,3 @@
{
"baseUrl": "https://safe-team.dev.gnosisdev.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should include /app here.

Copy link
Member Author

@DiogoSoaress DiogoSoaress Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are redirected with or without /app. I've changed it in the last commit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It redirects, but React Router will warning about it.

"prepare": "husky install"
"prepare": "husky install",
"cypress:open": "cypress open",
"cypress:run": "cypress run"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I get it right that it will run on safe-team.dev.gnosisdev.com?
How do I launch it on localhost?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can change baseUrl in cypress.json to localhost:3000/app

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the cy.visit("/") are going to prepend baseUrl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we change it to localhost then. And merge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the baseUrl to test against localhost

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DiogoSoaress DiogoSoaress merged commit 5151fc1 into dev Apr 1, 2022
@DiogoSoaress DiogoSoaress deleted the cypress-poc branch April 1, 2022 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants