Run CI builds with Sprockets 3.7.2 #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
sprockets-4-concurrent-fix
branch
from
3c95215
to
511f3c0
Compare
We can expect that sassc is installed since we have it as dependency. We do not need a custom loader.
There is a serious unfixed bug in sassc-ruby that causes issues when used with Sprockets 4.
tvdeyen
force-pushed
the
sprockets-4-concurrent-fix
branch
from
511f3c0
to
c7e8b34
Compare
tvdeyen
changed the title
tvdeyen
added a commit
that referenced
this pull request
Feb 25, 2020
- Do not use deprecated methods [#1737](#1737) ([tvdeyen](https://github.com/tvdeyen)) - Order contents by their position in its element [#1733](#1733) ([tvdeyen](https://github.com/tvdeyen)) - Eager load relations in elements trash [#1732](#1732) ([tvdeyen](https://github.com/tvdeyen)) - Run CI builds with Sprockets 3.7.2 [#1731](#1731) ([tvdeyen](https://github.com/tvdeyen)) - Re-organize development dependencies [#1730](#1730) ([tvdeyen](https://github.com/tvdeyen)) - Update pr template [#1729](#1729) ([tvdeyen](https://github.com/tvdeyen)) - Generate views without _view in the filename [#1728](#1728) ([tvdeyen](https://github.com/tvdeyen)) - Fix CI Builds [#1727](#1727) ([tvdeyen](https://github.com/tvdeyen)) - Fix page tagging condition: should_attach_to_menu? [#1725](#1725) ([mickenorlen](https://github.com/mickenorlen)) - Fix Alchemy.user_class_name constant conflict [#1724](#1724) ([mickenorlen](https://github.com/mickenorlen))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprockets 4 concurrency does not play well with SassC
See sass/sassc-ruby#167
Also removes a legacy sass loader that is not necessary anymore since ruby based sass gem has been deprecated and sassc is the only sass compiler left for ruby.