Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order contents by their position in its element #1733

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Feb 24, 2020

What is this pull request for?

Always order contents by their position in its element

Notable changes (remove if none)

Remove the essence_type acts_as_list scope condition as this feature was removed a long time ago.

Remove the essence type scope condition as this feature was removed
a long time ago.
@tvdeyen tvdeyen merged commit d9a5f6c into AlchemyCMS:master Feb 25, 2020
@tvdeyen tvdeyen deleted the fix-content-acts-as-list-scope branch February 25, 2020 11:26
tvdeyen added a commit that referenced this pull request Feb 25, 2020
- Do not use deprecated methods [#1737](#1737) ([tvdeyen](https://github.com/tvdeyen))
- Order contents by their position in its element [#1733](#1733) ([tvdeyen](https://github.com/tvdeyen))
- Eager load relations in elements trash [#1732](#1732) ([tvdeyen](https://github.com/tvdeyen))
- Run CI builds with Sprockets 3.7.2 [#1731](#1731) ([tvdeyen](https://github.com/tvdeyen))
- Re-organize development dependencies [#1730](#1730) ([tvdeyen](https://github.com/tvdeyen))
- Update pr template [#1729](#1729) ([tvdeyen](https://github.com/tvdeyen))
- Generate views without _view in the filename [#1728](#1728) ([tvdeyen](https://github.com/tvdeyen))
- Fix CI Builds [#1727](#1727) ([tvdeyen](https://github.com/tvdeyen))
- Fix page tagging condition: should_attach_to_menu?  [#1725](#1725) ([mickenorlen](https://github.com/mickenorlen))
- Fix Alchemy.user_class_name constant conflict [#1724](#1724) ([mickenorlen](https://github.com/mickenorlen))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant