feat(highlights): Added some missed highlights primarily for markup languages

[juniorsundar]

I have ported over most changes from #110 prior to the restructuring. Some were dropped because I found that they were redundant.

The rationale for this PR is I found that this theme does not have proper support for Neorg (and most other) markup files. I've selected formatting for highlight groups based on how Catppuccin and Tokyonight did it, though I've tried to keep it true to Nordic's flavour.

Here is a side by side comparison of the result:

[5-pebbles]

everything looks good as far as I can tell.

nice work!

[5-pebbles]

It looks awesome!

Old:

New:

[5-pebbles]

@AlexvZyl can this one get merged?

It's kind of miserable to work on markdown files without it.

[AlexvZyl]

Can we make to top heading yellow instead of red? We try to reserve red.

Other than that, this looks awesome, thanks!

[AlexvZyl]

It looks awesome!

Old:

New:

Nice.

[5-pebbles]

Can we make to top heading yellow instead of red? We try to reserve red.

Other than that, this looks awesome, thanks!

That is headlines.nvim I messed up and forgot it was enabled...

Here is what it looks like by default:

That was a mess-up on my part really sorry about that.

[5-pebbles]

And here is the old without headlines.nvim:

[juniorsundar]

Can we make to top heading yellow instead of red? We try to reserve red.

Other than that, this looks awesome, thanks!

@AlexvZyl Are you referring to the example with Neorg that I attached to the Pull Request? Or for the Markdown examples that @5-pebbles posted?

[AlexvZyl]

Can we make to top heading yellow instead of red? We try to reserve red.
Other than that, this looks awesome, thanks!

@AlexvZyl Are you referring to the example with Neorg that I attached to the Pull Request? Or for the Markdown examples that @5-pebbles posted?

I am referring to the example that you attached.

[juniorsundar]

Can we make to top heading yellow instead of red? We try to reserve red.
Other than that, this looks awesome, thanks!

@AlexvZyl Are you referring to the example with Neorg that I attached to the Pull Request? Or for the Markdown examples that @5-pebbles posted?

I am referring to the example that you attached.

Neorg seems to link to arbitrary tags (like Macro, Delimiter, etc.) for its heading highlights. So I decided to specifically designate highlight groups for markdown headings and linked them to the corresponding Neorg highlight tags. The heading highlights for markdown and neorg will now be synchronised.

H1 to H3 are bold faced. H4 is regular faced. H5-H6 is italicised.

[juniorsundar]

More examples:

[juniorsundar]

Also, (sorry to spam), I've found that there are some buggy interactions with the highlights when also using folke/noice.nvim

The Heading highlights for .norg files seem to revert when you switch to command mode :. I don't know if I should debug this issue, or offload it as a noice.nvim issue?

When not using noice.nvim this issue doesn't occur, so I'm certain that it isn't a nordic.nvim issue. My guess is that noice.nvim seems to mess around with the markdown highlights in someway or remaps that highlight group which seems to be messing things up.

Before Command mode:

After Command mode:

[AlexvZyl]

Can we make to top heading yellow instead of red? We try to reserve red.
Other than that, this looks awesome, thanks!

@AlexvZyl Are you referring to the example with Neorg that I attached to the Pull Request? Or for the Markdown examples that @5-pebbles posted?

I am referring to the example that you attached.

Neorg seems to link to arbitrary tags (like Macro, Delimiter, etc.) for its heading highlights. So I decided to specifically designate highlight groups for markdown headings and linked them to the corresponding Neorg highlight tags. The heading highlights for markdown and neorg will now be synchronised.

H1 to H3 are bold faced. H4 is regular faced. H5-H6 is italicised.

Perfect, thanks!

[AlexvZyl]

Also, (sorry to spam), I've found that there are some buggy interactions with the highlights when also using folke/noice.nvim

The Heading highlights for .norg files seem to revert when you switch to command mode :. I don't know if I should debug this issue, or offload it as a noice.nvim issue?

When not using noice.nvim this issue doesn't occur, so I'm certain that it isn't a nordic.nvim issue. My guess is that noice.nvim seems to mess around with the markdown highlights in someway or remaps that highlight group which seems to be messing things up.

Before Command mode:

After Command mode:

Definitely seems like it is a noice issue. You can open an issue there and link this PR.

[juniorsundar]

Also, (sorry to spam), I've found that there are some buggy interactions with the highlights when also using folke/noice.nvim
The Heading highlights for .norg files seem to revert when you switch to command mode :. I don't know if I should debug this issue, or offload it as a noice.nvim issue?
When not using noice.nvim this issue doesn't occur, so I'm certain that it isn't a nordic.nvim issue. My guess is that noice.nvim seems to mess around with the markdown highlights in someway or remaps that highlight group which seems to be messing things up.
Before Command mode:

After Command mode:

Definitely seems like it is a noice issue. You can open an issue there and link this PR.

folke/noice.nvim#656

The issue already exists there it seems, and it has been unaddressed since Nov 2023

[AlexvZyl]

Well, then that is not on us :) I will merge this this evening after I fixed our CI.

[AlexvZyl]

Thanks again!