Replace Source Code Pro with Anonymous Pro font #10826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason I'm proposing replacing SCP with AP is because there is a bug in firefox and/or MacOS which causes this font to render incorrectly. See: - https://bugzilla.mozilla.org/show_bug.cgi?id=1534503 - https://bugzilla.mozilla.org/show_bug.cgi?id=1520157 Anonymous Pro is a bit more lightweight and has at least been recently updated by its maintainers (1.44.0 was 3 months ago). SCP is definitely more ubiquitous and well-maintained but I would rather have a font that works everywhere. As an added bonus, this font is *much* more lightweight than SCP.
|
Automated checks report:
Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks. |
|
Here's a source with some samples of the font: https://www.marksimonson.com/fonts/view/anonymous-pro |
|
I also wanted to use this font, but there doesn't seem to be a well-maintained package on the npm registry: https://typeof.net/Iosevka/ |
tieujason330
approved these changes
Feb 1, 2020
|
Merged build finished. Test FAILed. |
|
Test FAILed. |
calvinjia
approved these changes
Feb 1, 2020
|
alluxio-bot, merge this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason I'm proposing replacing SCP with AP is because there is a
bug in firefox and/or MacOS which causes this font to render
incorrectly.
See:
Anonymous Pro is a bit more lightweight and has at least been recently
updated by its maintainers (1.44.0 was 3 months ago). SCP is definitely
more ubiquitous and well-maintained but I would rather have a font that
works everywhere. As an added bonus, this font is much more
lightweight than SCP.
Additionally, it seems the maintainers of the project have no desire to
address or look into what triggered the regression:
adobe-fonts/source-code-pro#217