-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Code Pro cannot be styled in Firefox #217
Comments
Why do the Google Fonts and Adobe Fonts versions work? Is it because they're being served without the SVG glyphs? If so, can we get a build of Source Code Pro without those SVG glyphs to work around the issue? I get that it's a Firefox bug, but web fonts that don't work in Firefox are kind of a deal breaker. |
Either that or they're serving an older version.
No, sorry. |
The reason I'm proposing replacing SCP with AP is because there is a bug in firefox and/or MacOS which causes this font to render incorrectly. See: - https://bugzilla.mozilla.org/show_bug.cgi?id=1534503 - https://bugzilla.mozilla.org/show_bug.cgi?id=1520157 Anonymous Pro is a bit more lightweight and has at least been recently updated by its maintainers (1.44.0 was 3 months ago). SCP is definitely more ubiquitous and well-maintained but I would rather have a font that works everywhere. As an added bonus, this font is *much* more lightweight than SCP. Additionally, it seems the maintainers of the project have no desire to address or look into what triggered the regression: adobe-fonts/source-code-pro#217 pr-link: #10826 change-id: cid-b0c413b42cf8cffd0913fbe581bde24d576efa89
This has been resolved with the latest release (see also #250): |
…dePro, r=GuillaumeGomez Update Source Code Pro and include italics Fixes rust-lang#65502. rust-lang#65665, a similar PR to this was merged but reverted because of rust-lang#65665 (comment). The issue in that comment is the upstream issue adobe-fonts/source-code-pro#217 which should now be fixed in the upstream since [2.032R-ro/1.052R-it/1.012R-VAR release](https://github.com/adobe-fonts/source-code-pro/releases/tag/2.032R-ro/1.052R-it/1.012R-VAR), so I think this can now be merged. A couple of notes from the original PR: * Since this PR changes the font set, I think docs.rs would have to be updated if this PR is merged. * The fonts have a double extension (.ttf.woff); this is to keep the names consistent with the upstream font release which does that to distinguish these from the .otf.woff files (Source Code Pro otf renders poorly on older Windows system apps).
For some reason, it's not possible to change the color of Source Code Pro in Firefox. It always renders as
#000
. It might be the same problem as #206?I've reproduced this in Firefox 54 and Firefox Quantum on macOS Mojave. I could not reproduce in either Firefox 54 or Quantum on Windows 10.
This happens with the OTF, TTF, WOFF and WOFF2 versions in the latest build, as well as several older builds I spot checked.
The issue is visible on the font demo page. Notice how the "Fork me on GitHub" banner has black text rather than white like in every other browser:
Also interesting to note is the versions served by Adobe Fonts and Google Fonts can be styled:
The text was updated successfully, but these errors were encountered: