Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken code rendering on macOS Firefox with no local copy of Source Code Pro #9

Closed
robinwhittleton opened this issue Jun 29, 2020 · 4 comments · Fixed by standardebooks/web#70
Closed

Fix broken code rendering on macOS Firefox with no local copy of Source Code Pro #9

robinwhittleton opened this issue Jun 29, 2020 · 4 comments · Fixed by standardebooks/web#70
Assignees
@robinwhittleton

Comments

@robinwhittleton
Copy link
Member

Something’s weird with our code display in Firefox on macOS: if you don’t have Source Code Pro installed locally it falls back to just black rendering, regardless of CSS.

I’ll have a dig into why this might be happening.
@robinwhittleton robinwhittleton self-assigned this Jun 29, 2020
@robinwhittleton
Copy link
Member Author

This is adobe-fonts/source-code-pro#217, which links through to https://bugzilla.mozilla.org/show_bug.cgi?id=1520157.

@acabal
Copy link
Member

acabal commented Jun 30, 2020

What if we just removed the local() part and relied on serving our own copy? Does it work then?

@robinwhittleton
Copy link
Member Author

I tried playing around with this and got sidetracked by finding a crashing bug in Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=1649676 if you’re interested). My feeling is no (local is actually allowing the working copy of Source Code Pro) but I’ll dig into this in more detail tonight to double-check

@acabal
Copy link
Member

acabal commented Jul 1, 2020

OK. If it doesn't work at all then we can switch to Fira. Maybe you can put together that pull request if you have some free time.

robinwhittleton added a commit to standardebooks/web that referenced this issue Jul 1, 2020
@robinwhittleton
Replace Source Code Pro with Fira Mono for code snippets
ec46a66 
The main reason to do this is to fix standardebooks/manual#9, but the font is also about 20% smaller which is a nice benefit.

Fira Mono is also licensed under OFL so no change there. I have no stylistic preference either way, but they’re broadly similar in look. Fira Mono has no italic faces, but we have no italic display of source code so no loss there.
@robinwhittleton robinwhittleton mentioned this issue Jul 1, 2020
Merged
acabal pushed a commit to standardebooks/web that referenced this issue Jul 1, 2020
@robinwhittleton @acabal
Replace Source Code Pro with Fira Mono for code snippets
b1b2dc4 
The main reason to do this is to fix standardebooks/manual#9, but the font is also about 20% smaller which is a nice benefit.

Fira Mono is also licensed under OFL so no change there. I have no stylistic preference either way, but they’re broadly similar in look. Fira Mono has no italic faces, but we have no italic display of source code so no loss there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinwhittleton robinwhittleton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Source Code Pro with Fira Mono for code snippets standardebooks/web
2 participants
@robinwhittleton @acabal