Add message regarding tenant level resources to ListByResourceGroup & ListBySubscriptions #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ListBySubscriptions
vishrutshah
previously requested changes
Jun 23, 2017
| @@ -251,10 +251,10 @@ Modelers: | |||
| <value>For the tracked resource '{0}', the x-ms-pageable extension values must be same for list by resource group and subscriptions operations.</value> | |||
| </data> | |||
| <data name="TrackedResourceListByResourceGroupOperationMissing" xml:space="preserve"> | |||
| <value>The tracked resource, '{0}', must have a list by resource group operation.</value> | |||
| <value>The tracked resource, '{0}', must have a list by resource group operation.(This rule does not apply for tenant level resources.)</value> | |||
There was a problem hiding this comment.
Can we detect tenant level resource from the path of the operation to improve the logic of the rule?
There was a problem hiding this comment.
Not as of now. This was decided in one of our earlier discussion
veronicagg
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and approve Related to #2389