Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message regarding tenant level resources to ListByResourceGroup & ListBySubscriptions #2390

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Add message regarding tenant level resources to ListByResourceGroup & ListBySubscriptions #2390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/AutoRest.Core/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/core/AutoRest.Core/Properties/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,10 @@ Modelers:
<value>For the tracked resource '{0}', the x-ms-pageable extension values must be same for list by resource group and subscriptions operations.</value>
</data>
<data name="TrackedResourceListByResourceGroupOperationMissing" xml:space="preserve">
<value>The tracked resource, '{0}', must have a list by resource group operation.</value>
<value>The tracked resource, '{0}', must have a list by resource group operation.(This rule does not apply for tenant level resources.)</value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we detect tenant level resource from the path of the operation to improve the logic of the rule?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as of now. This was decided in one of our earlier discussion

</data>
<data name="TrackedResourceListBySubscriptionsOperationMissing" xml:space="preserve">
<value>The tracked resource, '{0}', must have a list by subscriptions operation.</value>
<value>The tracked resource, '{0}', must have a list by subscriptions operation.(This rule does not apply for tenant level resources.)</value>
</data>
<data name="EmptyClientName" xml:space="preserve">
<value>Empty x-ms-client-name property.</value>
Expand Down