[Containerapp] Support debug console #7945
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp debug | cmd containerapp debug added |
|
Hi @fangjian0423, |
|
Containerapp |
microsoft-github-policy-service
bot
requested review from
yonzhan and
wangzelin007
fangjian0423
requested review from
yiliuTo
and removed request for
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
requested review from
yanzhudd,
zhoxing-ms,
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl,
jijohn14 and
Greedygre
src/containerapp/azext_containerapp/tests/latest/test_containerapp_scenario.py
Outdated
Show resolved
Hide resolved
|
|
|
Recommend title: |
| return "" | ||
|
|
||
| def _get_url(self, cmd, resource_group_name, name, revision, replica, container, startup_command): | ||
| containers = ContainerAppPreviewClient.get_replica(cmd, |
There was a problem hiding this comment.
is it possible to reuse the replica data we already loaded? seems like this will do another http call which is not that necessary
There was a problem hiding this comment.
the replica data we already loaded is in validation phase, seems it can't be reused here.
| except Exception as e: | ||
| stringErr = str(e) | ||
| if "Handshake status 400 Bad Request" in stringErr: | ||
| raise CLIInternalError("Debug Console feature is not allowed for the subscription.") |
There was a problem hiding this comment.
400 doesnt necessarily mean a feature flag issue. might be better to show detailed error messages or have an error code mapping
There was a problem hiding this comment.
the python websocket library didn't read response body if response code is not in (301, 302, 303 and 101). So we can't read the body and only can read 400 reponse code.
Given we will remove feature flag in the future, let me remove this logic.
There was a problem hiding this comment.
BTW, the newest websocket client support get response body: https://github.com/websocket-client/websocket-client/blob/master/websocket/_handshake.py#L146 . It is possible to upgrade websocket client in azure-cli-extension?
|
|
||
|
|
||
| def _set_debug_defaults(cmd, namespace): | ||
| app = ContainerAppPreviewClient.show(cmd, namespace.resource_group_name, namespace.name) |
There was a problem hiding this comment.
we can list revisions here and see: 1) if we got 404 error or None object then the container app doesnt exist 2) if we got an empty array then the container app exists but doesnt have any revisions
and the revision list data could be reused in checking user input parameter "targetContainer"
There was a problem hiding this comment.
IMO. List revisions will return all revision, this is not a good choice. If customer has lots of revisions, the payload will be big enough.
There was a problem hiding this comment.
normally the number of revisions in a single container app wont be too much. currently only 3.7% of container apps are in multiple active revision mode.
btw if you take a closer look at the container app payload and revision payload you will see container app is much larger than just a revision.
There was a problem hiding this comment.
It seems this API will return all the revisions, which are active or not active.
we have a discussion here: #7945 (comment) |
Feature doc: https://github.com/serverless-paas-balam/k4apps/discussions/4846
Some cases:
az containerapp debug --name {containerappname} --resource-group {rg} az containerapp debug --name {containerappname} --resource-group {rg} --revision {revision_name} az containerapp debug --name {containerappname} --resource-group {rg} --revision {revision_name} --replica {replica_name} az containerapp debug --name {containerappname} --resource-group {rg} --revision {revision_name} --replica {replica_name} --container {container_name}This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.